Fixes to EuiSearchBar etc types#3147
Conversation
|
@bevacqua I think this PR address most of the points you raised in #3138. The only one left is the @chandlerprall we could address this by moving |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3147/ |
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
we could address this by moving autoClose into the FieldValueSelectionFilterConfigType type - what do you think? It would mean fiddling about default props and such.
I don't see how autoClose could ever have been used in its current form. We don't export FieldValueSelectionFilter in a consumable way, so I believe autoClose can be moved to the config object with no problems.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3147/ |
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM! Thanks @pugnascotia
|
Thanks folks! |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3147/ |
4 participants
Closes #3138.
FilterConfigtoSearchFilterConfigand export it viaEuiSearchBar.FieldValueOptionTypeviaEuiSearchBar.EuiSearchBoxPropsto extendEuiFieldSearchProps, so that it includes all the HTML properties such asdisabled. Also rework the related component code to forward on more props via...rest.